Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spv-out] fix countLeadingZeros impl #2258

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Feb 20, 2023

  • id should have had the result of the last operation
  • MathOp::Custom should have been returned since we later execute: self.cached[expr_handle] = id;
  • removed unnecessary bitcast

@evahop
Copy link
Contributor

evahop commented Feb 20, 2023

Sorry about that. This was done in tandem with the glsl backend. Looks like aspects of that ended up over here without too much consideration.

@teoxoy
Copy link
Member Author

teoxoy commented Feb 20, 2023

No worries, I haven't noticed it either.
SPV validation tests also didn't catch it because we never used the returned value.

Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks better now.

@teoxoy teoxoy enabled auto-merge (squash) February 20, 2023 20:36
@teoxoy teoxoy merged commit cde457c into gfx-rs:master Feb 20, 2023
@teoxoy teoxoy deleted the spv-fix-countLeadingZeros branch October 18, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants