Introduce Expression::Literal.
#2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
force-pushed
the
expression-literal
branch
from
4a1a93f
to
e172514
Compare
|
For the record, I've checked all the SPIR-V snapshots and they look fine. I haven't actually reviewed the code changes yet. |
jimblandy
force-pushed
the
expression-literal
branch
from
e172514
to
d8cc697
Compare
jimblandy
force-pushed
the
expression-literal
branch
from
d8cc697
to
25d46ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #2266, which I'm trying to break down into smaller pieces that I can review. @teoxoy is the author; I'll figure out how to fix up the commit to say so tomorrow.
This introduces
Expression::Literalto the IR, and supports it in the backends, but there's nothing in the front ends to introduce such expressions, so in its current state it has no effect on the snapshots.This depends on #2331 and #2332.