[wgsl-in] Allow sign() to take int argument #2463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2458.
The main work here is to make it work on metal, which does not have an
int
overload ofsign()
. So we introduce anaga_isign
polyfill function there.Currently the metal backend always emits the
naga_isign
polyfill. What is a good way to only do that if necessary? We need to declare the function before it's used, so we can't do it after writing out the functions. Is there some mechanism to visit all expressions without duplicating a lot of logic?