Skip to content
This repository has been archived by the owner on Jan 29, 2025. It is now read-only.

[glsl-in] Expression ownership #541

Closed
wants to merge 1 commit into from

Conversation

pjoe
Copy link
Collaborator

@pjoe pjoe commented Mar 4, 2021

Just copy pasted info for easy ref:

GLSL-in shoud roughly following wgsl-in:

  1. Generate Expression::Load whenever we operate on a value of a variable (both locals and globals)
  2. Track the expressions we produce (possibly using Emitter struct that's currently shared between spv-in and wgsl-in):
  • flush (into Statement::Emit) before adding a statement using any of the expressions
  • exclude the Expression::Constant and Expression::Call by flushing before we add them, and restarting the emitter afterwards

Copy link
Contributor

@monocodus monocodus bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an autogenerated code review.

Checker summary (by rust_clippy):
The tool has found 3 warnings, 0 errors.

@JCapucho
Copy link
Collaborator

Closing this since #889 already implements this for the new parser

@JCapucho JCapucho closed this May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants