move bin/naga.rs to a separate crate in workspace #938
Conversation
|
Maybe we can enable all features for bin target? And remove all feature gates from the bin code. Are there any disadvantages, except compile time? |
I don't see any, except maybe binary size. Here's the (approximate) difference in compile speed:
|
|
I'm getting warmed up to this path, especially since |
naga-cli/Cargo.toml
Outdated
| [[bin]] | ||
| name = "naga" | ||
| path = "src/main.rs" | ||
|
|
||
| [dependencies] | ||
| naga = { path = "../" } | ||
| naga = { path = "../", features = ["wgsl-in", "wgsl-out", "glsl-in", "glsl-out", "spv-in", "spv-out", "msl-out", "hlsl-out", "dot-out"] } |
There was a problem hiding this comment.
I wish there was "all_features = true"
There was a problem hiding this comment.
The serialize and deserialize features aren't needed anyway. glsl-validate should probably be enabled as well?
There was a problem hiding this comment.
we can keep the serialization off now, indeed, but the validation for GLSL should be ON
naga-cli/src/main.rs
Outdated
| @@ -288,10 +269,7 @@ fn main() { | |||
| } | |||
| other => { | |||
| let _ = params; | |||
There was a problem hiding this comment.
no longer needed (here and in other places)
|
Also |
jakobhellermann
force-pushed
the
naga-workspace
branch
from
4ee5332 to
f50e262
Compare
I added the |
* move bin/naga.rs to a separate crate * enable all shader languages for naga binary * [naga-cli] add env logger * [naga-cli] remove unneccessary code * [naga-cli]enable glsl-validate feature * move naga-cli to cli, add trailing newline * remove commented env_logger dependency
Splitting this off #934 for a place to discuss this change.
Because of the
default-members, runningcargo run --features spv-out,wgsl-in input.wgsl output.spvstill works.A disadvantage is that all the cargo features have to be duplicated.