Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply the correct result type when lifting functions #210

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

incertia
Copy link
Contributor

@incertia incertia commented Aug 1, 2021

should address #209 but i'm not sure if what i did is entirely good

either way it's a 2 line change so it should be quick and easy

as a side note it looks like 0.8.0 was not pushed to crates.io

@MarijnS95
Copy link
Collaborator

as a side note it looks like 0.8.0 was not pushed to crates.io

See #204 and all the relevant linked issues, SPIRV-Headers caused a semver issue leading to 0.8.0 to be yanked. We're in the process of rectifying that and can hopefully merge most of the outstanding PRs before finally publishing the long-awaited crate updates ASAP 😬

Copy link
Collaborator

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely familiar with this code either, but the end result looks sound. At least we're not appending a new "void" type for every function anymore which is a good thing.

@Jasper-Bekkers Jasper-Bekkers linked an issue Aug 16, 2021 that may be closed by this pull request
@msiglreith msiglreith merged commit 0fed630 into gfx-rs:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiftContext::convert struggles with linked multi-stage SPIRV
3 participants