GetBindGroupLayout 'raises error' instead of panicing on invalid index #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Will create a backport to |
rajveermalviya
pushed a commit
to rajveermalviya/wgpu-native
that referenced
this pull request
Nov 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref discussion in pygfx/wgpu-py#423
We have
wgpuRenderPipelineGetBindGroupLayoutandwgpuComputePipelineGetBindGroupLayout. End-users calling this code (e.g. people writing code against wgpu-py), may accidentally use an invalid index, which now causes a panic. In order for a wrapper to handle such errors gracefully, they must either know the number of layouts, or the call should not panic but generate an error instead. This PR does the latter (leading to a Python exception in wgpu-py).Tested with wgpu-py (on the v0.18.1.1 tag).