Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cfg_aliases and apply cfgs inline #413

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

rajveermalviya
Copy link
Collaborator

@rajveermalviya rajveermalviya commented Aug 27, 2024

Addresses #351 (comment)

@almarklein almarklein merged commit da00684 into gfx-rs:trunk Aug 27, 2024
16 checks passed
@rajveermalviya rajveermalviya deleted the pr-fix-cfgs branch August 27, 2024 10:26
@hmaarrfk
Copy link

hmaarrfk commented Sep 1, 2024

Thanks for addressing this quickly. I am going to try to give this a go in case it fixes things.

Is there any chance of a new release for me to avoid « back porting » the patch?

@hmaarrfk
Copy link

hmaarrfk commented Sep 1, 2024

I think our issues at conda-forge are likely more widespread. So it may be unrelated to this

@almarklein
Copy link
Collaborator

Is there any chance of a new release for me to avoid « back porting » the patch?

A new release was just published.

@hmaarrfk
Copy link

hmaarrfk commented Sep 2, 2024

Thank you for the release. whatever happened it seems like osx-arm build is fixed.

@hmaarrfk
Copy link

hmaarrfk commented Sep 2, 2024

Definitely the .2 release helped.

It might have been some of the dependencies that you updated here.

So in either case, thank you again!
xref: conda-forge/wgpu-native-feedstock#23 (tried to revert to the .1 and you see the failure again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants