fix: discard cmd. enc. buf. on wgpu_core::Global::command_encoder_drop

CHANGELOG.md

@@ -113,6 +113,7 @@ Bottom level categories:
 - Fix panic when creating a surface while no backend is available. By @wumpf [#5166](https://github.com/gfx-rs/wgpu/pull/5166)
 - Correctly compute minimum buffer size for array-typed `storage` and `uniform` vars. By @jimblandy [#5222](https://github.com/gfx-rs/wgpu/pull/5222)
 - Fix timeout when presenting a surface where no work has been done. By @waywardmonkeys in [#5200](https://github.com/gfx-rs/wgpu/pull/5200)
+- Fix an issue where command encoders weren't properly freed if an error occurred during command encoding. By @ErichDonGubler in [#5251](https://github.com/gfx-rs/wgpu/pull/5251).
 
 #### WGL
 

wgpu-core/src/command/mod.rs

@@ -75,7 +75,7 @@ impl<A: HalApi> CommandEncoder<A> {
  Ok(())
  }
 
- fn discard(&mut self) {
+ pub(crate) fn discard(&mut self) {
  if self.is_open {
  self.is_open = false;
  unsafe { self.raw.discard_encoding() };
@@ -112,7 +112,7 @@ pub(crate) struct DestroyedBufferError(pub id::BufferId);
 pub(crate) struct DestroyedTextureError(pub id::TextureId);
 
 pub struct CommandBufferMutable<A: HalApi> {
- encoder: CommandEncoder<A>,
+ pub(crate) encoder: CommandEncoder<A>,
  status: CommandEncoderStatus,
  pub(crate) trackers: Tracker<A>,
  buffer_memory_init_actions: Vec<BufferInitTrackerAction<A>>,

wgpu-core/src/device/global.rs

@@ -1377,6 +1377,7 @@ impl Global {
  .command_buffers
  .unregister(command_encoder_id.transmute())
  {
+ cmd_buf.data.lock().as_mut().unwrap().encoder.discard();
  cmd_buf
  .device
  .untrack(&cmd_buf.data.lock().as_ref().unwrap().trackers);