Don't compare booleans

gfx-rs · Apr 18, 2021 · 280ba30 · 280ba30
1 parent 92886b4
commit 280ba30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/wgpu-core/src/device/mod.rs b/wgpu-core/src/device/mod.rs
@@ -1433,7 +1433,7 @@ impl<B: GfxBackend> Device<B> {
                                 });
                             }
                             // Check the actual sampler to be non-filtering, if required
-                            if filtering < sampler.filtering {
+                            if sampler.filtering && !filtering {
                                 return Err(Error::WrongSamplerFiltering {
                                     binding,
                                     layout_flt: filtering,

diff --git a/wgpu-core/src/validation.rs b/wgpu-core/src/validation.rs
@@ -916,9 +916,9 @@ impl Interface {
                         sample_type: wgt::TextureSampleType::Float { filterable },
                         ..
                     } => match sampler_layout.ty {
-                        wgt::BindingType::Sampler { filtering, .. } if filtering > filterable => {
-                            Some(FilteringError::NonFilterable)
-                        }
+                        wgt::BindingType::Sampler {
+                            filtering: true, ..
+                        } if !filterable => Some(FilteringError::NonFilterable),
                         _ => None,
                     },
                     wgt::BindingType::Texture {