dont panic when submitting same commandbuffer multiple times (#2449)

gfx-rs · Feb 2, 2022 · e50b62f · e50b62f
1 parent 63dfd98
commit e50b62f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/deno_webgpu/01_webgpu.js b/deno_webgpu/01_webgpu.js
@@ -1474,6 +1474,9 @@
  queueRid: device.rid,
  commandBuffers: commandBufferRids,
  });
+ for (const commandBuffer of commandBuffers) {
+ commandBuffer[_rid] = undefined;
+ }
  device.pushError(err);
  }
 

diff --git a/deno_webgpu/src/queue.rs b/deno_webgpu/src/queue.rs
@@ -30,15 +30,19 @@ pub fn op_webgpu_queue_submit(
 
  let mut ids = vec![];
 
- for rid in args.command_buffers {
+ for rid in &args.command_buffers {
  let buffer_resource = state
  .resource_table
- .get::<super::command_encoder::WebGpuCommandBuffer>(rid)?;
+ .get::<super::command_encoder::WebGpuCommandBuffer>(*rid)?;
  ids.push(buffer_resource.0);
  }
 
  let maybe_err = gfx_select!(queue => instance.queue_submit(queue, &ids)).err();
 
+ for rid in args.command_buffers {
+ state.resource_table.close(rid)?;
+ }
+
  Ok(WebGpuResult::maybe_err(maybe_err))
 }