Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sRGB Conversion Not Done for EGL < 1.5 #1667

Closed
zicklag opened this issue Jul 15, 2021 · 5 comments · Fixed by #1671
Closed

sRGB Conversion Not Done for EGL < 1.5 #1667

zicklag opened this issue Jul 15, 2021 · 5 comments · Fixed by #1671
Assignees
@cwfitzgerald
Labels
help required We need community help to make this happen. type: bug Something isn't working

Comments

@zicklag
Copy link
Contributor

zicklag commented Jul 15, 2021

Description
I think sRGB converison is not currently working for the GL backend with EGL < 1.6 on Linux. The issue was originally found in #1627.

( #1627 (comment) )

@cwfitzgerald said:

Yeah my haswell rig has srgb issues on both vk and gl.

We have fixed the vulkan issue, but haven't done anything about GL yet.

Repro steps

Expected vs observed behavior
All of the examples appear darker in color than the vulkan ones. ( after we fixed vulkan in #1651 )

Extra materials

Platform
I was unable to reproduce this on my machine using Mesa Intel(R) UHD Graphics (CML GT2), but @cwfitzgerald mentioned having issues on his haswell rig.
@kvark kvark added external: driver-bug A driver is causing the bug, though we may still want to work around it type: bug Something isn't working help required We need community help to make this happen. labels Jul 15, 2021
@cwfitzgerald cwfitzgerald removed the external: driver-bug A driver is causing the bug, though we may still want to work around it label Jul 15, 2021
@cwfitzgerald
Copy link
Member

This isn't actually a driver bug because EGL doesn't support SRGB surfaces until 1.5, and all GL devices (including my RPI) with 1.4 are having colorspace issues.

@kvark
Copy link
Member

kvark commented Jul 15, 2021

@cwfitzgerald does RPi support https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_gl_colorspace.txt ?
Adding support for it in wgpu-hal/GLES should be trivial.

@kvark
Copy link
Member

kvark commented Jul 15, 2021

... and if neither EGL-1.5 or this extension are present, then we'll just no report SRGB formats as available for the swapchain.

@cwfitzgerald
Copy link
Member

It seams like both my haswell and the rpi support it, so that should be good to use.

@zicklag zicklag changed the title sRGB Conversion Not Done for EGL < 1.6 sRGB Conversion Not Done for EGL < 1.5 Jul 16, 2021
@cwfitzgerald cwfitzgerald self-assigned this Jul 16, 2021
@cwfitzgerald
Copy link
Member

Lemme see if I can toss together a PR for this.

@cwfitzgerald cwfitzgerald mentioned this issue Jul 16, 2021
Merged
@bors bors bot closed this as completed in 6c711ad Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwfitzgerald cwfitzgerald

Labels
help required We need community help to make this happen. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use EGL_KHR_gl_colorspace for srgb if available cwfitzgerald/wgpu
3 participants
@kvark @cwfitzgerald @zicklag