Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vulkan Backend Texture Format Mapping #1651

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fix Vulkan Backend Texture Format Mapping #1651

merged 1 commit into from
Jul 14, 2021

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented Jul 14, 2021

Fixes the Bgra8UnormSrgb texture format.

Connections
Resolves #1646.

Description
Fixes the mappings between the Bgra8UnormSrgb and Bgra8Unorm texture formats and their Vulkan equivalents.

Testing
Tested on my Ubuntu 20.04 machine on:

  • Intel(R) UHD Graphics (CML GT2) (Vulkan)
  • GeForce GTX 1650 (Vulkan)

@zicklag
Fix Vulkan Backend Texture Format Mapping
2896a6e 
Fixes the Bgra8UnormSrgb texture format.

Resolves gfx-rs#1646.
@zicklag zicklag mentioned this pull request Jul 14, 2021
Closed
cwfitzgerald
cwfitzgerald approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 14, 2021

Build succeeded:

@bors bors bot merged commit f11639e into gfx-rs:master Jul 14, 2021
@zicklag zicklag deleted the vulkan-srgb branch July 14, 2021 01:46
@zicklag zicklag mentioned this pull request Jul 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulkan Backend Not Doing Gamma Correction/sRGB Conversion
2 participants
@zicklag @cwfitzgerald