Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using D3DCompile is problematic #1712

Closed
kvark opened this issue Jul 23, 2021 · 4 comments
Closed

Using D3DCompile is problematic #1712

kvark opened this issue Jul 23, 2021 · 4 comments
Labels
api: dx12 Issues with DX12 or DXGI external: upstream Issues happening in lower level APIs or platforms type: bug Something isn't working

Comments

@kvark
Copy link
Member

kvark commented Jul 23, 2021

For DX12 shaders compiled with D3DCompile internally, we are seeing problems.
It doesn't allow fixed-array sizes to be larger than 65K, and it doesn't like to dynamically index into them. It considers itself "forced" to unroll a loop that just iterates elements in fixed-size arrays.
@kvark kvark added type: bug Something isn't working external: upstream Issues happening in lower level APIs or platforms labels Jul 23, 2021
@kvark
Copy link
Member Author

kvark commented Jul 26, 2021

A more detailed issue 998 on Tint, thanks @ben-clayton for the link!

@cwfitzgerald
Copy link
Member

#2722 will break our hard dep on FXC, though it will always be there for a fallback.

Patryk27 pushed a commit to Patryk27/wgpu that referenced this issue Nov 23, 2022
@jimblandy
Fix a few stray uses of "storage class". (gfx-rs#1712)
f3e6153
@teoxoy teoxoy added api: dx12 Issues with DX12 or DXGI api: dx11 labels Feb 24, 2023
@teoxoy
Copy link
Member

teoxoy commented Feb 24, 2023

We are tracking dynamic indexing in #4460.

doesn't allow fixed-array sizes to be larger than 65K

Not sure what we can do about this though, split them?

@cwfitzgerald
Copy link
Member

This should be covered by

@teoxoy teoxoy mentioned this issue Oct 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: dx12 Issues with DX12 or DXGI external: upstream Issues happening in lower level APIs or platforms type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @cwfitzgerald @teoxoy