Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_buffer on another thread can block get_current_texture for an extra frame #2394

Closed
danielkeller opened this issue Jan 15, 2022 · 2 comments
Labels
area: performance How fast things go type: bug Something isn't working

Comments

@danielkeller
Copy link

I'm using wgpu on macos/metal, and when I call write_buffer on a different thread from get_current_texture, about 20% of the calls to write_buffer will block both calls for an extra ~16 ms. Here's a screenshot of puffin viewer showing the problem:
image
It looks like write_buffer might be taking a lock at just the wrong moment and causing get_current_texture to miss the screen refresh, and locking up both threads until the next screen refresh.

@danielkeller danielkeller changed the title write_buffer on antother thread can block get_current_texture for an extra frame write_buffer on another thread can block get_current_texture for an extra frame Jan 15, 2022
@kvark
Copy link
Member

kvark commented Jan 16, 2022

Similarly to #2395, this is blocked on #2272

@kvark kvark added area: performance How fast things go type: bug Something isn't working labels Jan 16, 2022
@cwfitzgerald
Copy link
Member

Obsoleted by #2710

@cwfitzgerald cwfitzgerald closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: performance How fast things go type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants