Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wgpu_core::RenderBundleEncoder::finish a bit harsh when offered invalid pipelines #2665

Closed
jimblandy opened this issue May 16, 2022 · 0 comments · Fixed by #2666
Closed

wgpu_core::RenderBundleEncoder::finish a bit harsh when offered invalid pipelines #2665

jimblandy opened this issue May 16, 2022 · 0 comments · Fixed by #2666
Assignees
@jimblandy
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

When wgpu_render_bundle_set_pipeline is given an invalid pipeline (say, because the shader module encountered a compilation error), the next call to RenderBundleEncoder::finish panics, instead of returning a RenderCommandError as it would for other problems, and as command_encoder_run_render_pass_impl would if we were dealing with a render pass instead of a bundle.
@jimblandy jimblandy added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling labels May 16, 2022
@jimblandy jimblandy self-assigned this May 16, 2022
jimblandy added a commit to jimblandy/wgpu that referenced this issue May 16, 2022
@jimblandy
Report invalid pipelines in render bundles as errors, not panics.
0909a65 
Fixes gfx-rs#2665.
@jimblandy jimblandy mentioned this issue May 16, 2022
Merged
jimblandy added a commit that referenced this issue May 16, 2022
@jimblandy
Report invalid pipelines in render bundles as errors, not panics.
b51fd85 
Fixes #2665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimblandy jimblandy

Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report invalid pipelines in render bundles as errors, not panics. jimblandy/wgpu
1 participant
@jimblandy