Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate cargo-nextest is being used in tests #3285

Closed
cwfitzgerald opened this issue Dec 11, 2022 · 0 comments · Fixed by #3293
Closed

Validate cargo-nextest is being used in tests #3285

cwfitzgerald opened this issue Dec 11, 2022 · 0 comments · Fixed by #3293
Labels
area: tests Improvements or issues with our test suite help required We need community help to make this happen. type: enhancement New feature or request

Comments

@cwfitzgerald
Copy link
Member

There are various cases where our test suite fails due to cargo test running each test in the same process - we should implement a check in the test harness that terminates the process if more than one test context is initialized in a process. We can do this by xchg-ing with an atomic bool and asserting that the resulting value is false.

This check will need to be disabled on the web.
@cwfitzgerald cwfitzgerald added area: tests Improvements or issues with our test suite type: enhancement New feature or request labels Dec 11, 2022
@cwfitzgerald cwfitzgerald changed the title Validate cargo-nextest is being used in years Validate cargo-nextest is being used in tests Dec 11, 2022
@cwfitzgerald cwfitzgerald added the help required We need community help to make this happen. label Dec 11, 2022
@cwfitzgerald cwfitzgerald mentioned this issue Dec 14, 2022
Merged
3 tasks
cwfitzgerald added a commit that referenced this issue Dec 15, 2022
@cwfitzgerald
Error when not using cargo-nextest (#3293)
2480eff 
Closes #3285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tests Improvements or issues with our test suite help required We need community help to make this happen. type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error when not using cargo-nextest cwfitzgerald/wgpu
1 participant
@cwfitzgerald