Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are TextureCopyView::origin::{x,y,z} f32's? #419

Closed
fintelia opened this issue Dec 26, 2019 · 1 comment · Fixed by #420
Closed

Why are TextureCopyView::origin::{x,y,z} f32's? #419

fintelia opened this issue Dec 26, 2019 · 1 comment · Fixed by #420
Labels
area: api Issues related to API surface good first issue Good for newcomers type: bug Something isn't working

Comments

@fintelia
Copy link
Contributor

The doc comment on the origin field says that it indicates a specific texel, suggesting that integers should be used instead:

origin: Origin3d
[−] The base texel of the texture in the selected mip_level.
@kvark
Copy link
Member

kvark commented Dec 26, 2019

This is a mistake, thanks for pointing to it! Would you want to file a PR (against wgpu repo) to fix it?

@kvark kvark transferred this issue from gfx-rs/wgpu-rs Dec 26, 2019
@kvark kvark added area: api Issues related to API surface type: bug Something isn't working good first issue Good for newcomers labels Dec 26, 2019
@fintelia fintelia mentioned this issue Dec 26, 2019
Merged
bors bot added a commit that referenced this issue Dec 26, 2019
@bors @fintelia
Merge #420
f34815a 
420: Make Origin3d::{x,y,z} all have type u32 r=kvark a=fintelia

Fixes #419 

Co-authored-by: Jonathan Behrens <fintelia@gmail.com>
bors bot added a commit that referenced this issue Dec 30, 2019
@bors @fintelia
Merge #420
d75e018 
420: Make Origin3d::{x,y,z} all have type u32 r=kvark a=fintelia

Fixes #419 

Co-authored-by: Jonathan Behrens <fintelia@gmail.com>
@bors bors bot closed this as completed in 890bbcf Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issues related to API surface good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Origin3d::{x,y,z} all have type u32 fintelia/wgpu
2 participants
@kvark @fintelia