-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make naga::back
items public to support out of tree backends
#5398
Comments
+1 I'm also interested in this feature |
LegNeato
added a commit
to LegNeato/wgpu
that referenced
this issue
Mar 16, 2024
This helps out-of-tree backends. Fixes gfx-rs#5398.
teoxoy
pushed a commit
that referenced
this issue
Apr 2, 2024
This helps out-of-tree backends. Fixes #5398.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
As suggested in a matrix thread, I am trying to convert the rust backend in #5175 to an out of tree maintained backend. To do so, I need some types in
naga::back
to be public.For example, my PR uses
wgpu/naga/src/back/mod.rs
Line 77 in a63bec8
It seems pretty much everything in
naga::back
should be public if out of tree backends are encouraged as the module is meant for backends to use.I'm fine dealing with breakage if these are
pub
and marked as unstable and/or hidden in the docs.Describe the solution you'd like
The items in
naga::back
bepub
.Describe alternatives you've considered
pub
.Additional context
I was told in matrix to open an issue when something prevents the backend from being out of tree. I am happy to put up a PR flipping what I need to
pub
, but I wanted to open this issue first to see if there is a different preferred solution.The text was updated successfully, but these errors were encountered: