Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix winit event loop in the triangle example #128

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Fix winit event loop in the triangle example #128

merged 1 commit into from
Apr 22, 2019

Conversation

psincf
Copy link
Contributor

@psincf psincf commented Apr 22, 2019

It's the refactored #122 PR

@kvark
Copy link
Member

kvark commented Apr 22, 2019

@psincf note: you should just force-push the new commits to the same branch your PR was open. There is never need to open a new PR.
bors r+

bors bot added a commit that referenced this pull request Apr 22, 2019
128: Fix winit event loop in the triangle example r=kvark a=psincf

It's the refactored #122 PR

Co-authored-by: psincf <44228825+psincf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Apr 22, 2019

Build succeeded

@bors bors bot merged commit e70b01c into gfx-rs:master Apr 22, 2019
@psincf psincf deleted the event-loop branch April 22, 2019 22:07
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this pull request Feb 23, 2020
128: Small updates r=kvark a=Coder-256

Enable Travis CI cache, disable [deprecated container-based builds](https://docs.travis-ci.com/user/reference/trusty/#container-based-infrastructure), and add `red.png` to `.gitignore` (output from `cargo run --example capture`).

Co-authored-by: Jacob Greenfield <jacob@jacobgreenfield.me>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
128: Small updates r=kvark a=Coder-256

Enable Travis CI cache, disable [deprecated container-based builds](https://docs.travis-ci.com/user/reference/trusty/#container-based-infrastructure), and add `red.png` to `.gitignore` (output from `cargo run --example capture`).

Co-authored-by: Jacob Greenfield <jacob@jacobgreenfield.me>
Patryk27 pushed a commit to Patryk27/wgpu that referenced this pull request Nov 23, 2022
* Initial glsl es 300 support

* Set float default precision

* Generate interface blocks and check storage class in es

* Added more checks on es and fixed uniform blocks with same name type

* Added image checks

* Added the test to the makefile

* applied comments
RandyMcMillan pushed a commit to RandyMcMillan/wgpu that referenced this pull request Jun 19, 2024
Remove unnecessary bound in iced_web Container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants