Move clear_texture impl from wgpu-hal to wgpu-core #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
force-pushed
the
core-cleartexture
branch
from
7267512 to
a28319b
Compare
kvark
requested changes
Oct 12, 2021
…mip size for texture clear
|
@kvark good to go now I believe |
kvark
requested changes
Oct 12, 2021
There was a problem hiding this comment.
I'm sorry, it looks like one of my comments didn't show up, and still needs to be addressed.
bytes_per_row has to be aligned. See
wgpu/wgpu-core/src/device/queue.rs
Line 405 in 1759722
|
ohh another good catch. Makes me very happy we have to implement this monster only once now. Fixed! |
kvark
approved these changes
Oct 13, 2021
|
CI is unhappy. Otherwise, good to go! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Another small steps towards #1688 (texture zero init)
Description
Moves clear_texture implementation from wgpu-hal to wgpu-core.
Previously, the only backend profiting from this was Vulkan and it still limited what we could use it on, notably compressed textures did not work. The new impl is almost identical to the Metal & DX12 implementation previously -> less code to maintain.
collect_zero_buffer_copies_for_clear_texturemay look awkwardly separated out, but is very useful in this form for my texture init wip branch where I can use this to bundle up operations that are then sent off a single wgpu-hal callTesting
New test going through all texture formats and kinds and clearing them. No reading back yet, but verifies at least that backend impls are happy and nothing crashes. List of formats put in there should be useful for other upcoming "try this with all formats" tests.