Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do texture init via clear passes when possible #2307

Merged
merged 27 commits into from
Dec 28, 2021
Merged

Do texture init via clear passes when possible #2307

merged 27 commits into from
Dec 28, 2021

Commits on Dec 26, 2021

  1. CLEAR_COMMANDS extension is now more of a window into wgpu zero-init 

    this has mostly implications on the constraints, but also allows a more leaky documentation which makes sense for this non-standard function as there is no other place to look it up
    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    3898c20 View commit details
    Browse the repository at this point in the history

  2. clear_texture via renderpasses wip

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    1858144 View commit details
    Browse the repository at this point in the history

  3. 3D depth textures are no longer allowed, volumes are always cleared v… 

    …ia CPY_DST
    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    118bb2b View commit details
    Browse the repository at this point in the history

  4. cleanup texture's clear_views

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    09b940d View commit details
    Browse the repository at this point in the history

  5. rename CLEAR_COMMANDS to CLEAR_TEXTURE

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    2007f11 View commit details
    Browse the repository at this point in the history

  6. separate clear_texture into reusable & more descriptive parts

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    f233a81 View commit details
    Browse the repository at this point in the history

  7. texture clear views are now created ahead of time

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    16fe26c View commit details
    Browse the repository at this point in the history

  8. discarded surface fixup goes through new clear_texture method now

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    e3e530f View commit details
    Browse the repository at this point in the history

  9. onq ueue texture initialization now goes threw clear_texture 

    pending inits need to store Stored textures now though, causing more ref count bumping
    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    a760ddd View commit details
    Browse the repository at this point in the history

  10. texture init on queue_write_texture now also goes through new clear_t… 

    …exture
    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ad5ed2c View commit details
    Browse the repository at this point in the history

  11. transfer functions on commandbuffer use now new texture init route

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    35a520f View commit details
    Browse the repository at this point in the history

  12. merge collect_zero_buffer_copies_for_clear_texture into clear_texture… 

    …_via_buffer_copies
    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    d59a38b View commit details
    Browse the repository at this point in the history

  13. clear functions now take TextureInitRange

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    44b5e92 View commit details
    Browse the repository at this point in the history

  14. Fix clippy lints

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    60a5bba View commit details
    Browse the repository at this point in the history

  15. command_encoder_clear_texture no longer takes write lock on texture

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    2b31b6b View commit details
    Browse the repository at this point in the history

  16. TextureClearMode encodes now is_color

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    5761e98 View commit details
    Browse the repository at this point in the history

  17. code cleanup, mostly about use

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    6732a69 View commit details
    Browse the repository at this point in the history

  18. Handle volume textures in clear_texture_via_render_passes properly

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ac436b5 View commit details
    Browse the repository at this point in the history

  19. texture clear no longer requires id::Stored

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    11babe8 View commit details
    Browse the repository at this point in the history

  20. init tracking fixes for volumes and init on partial subresource writes

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    6d8b986 View commit details
    Browse the repository at this point in the history

  21. texture creation enforces COPY_DST only if absolutely necessary

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ad95963 View commit details
    Browse the repository at this point in the history

  22. unrolled functional chain, reduce unsafe scope size

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    614725f View commit details
    Browse the repository at this point in the history

  23. fix clippy lints

    @Wumpf
    Wumpf committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    dc24f94 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. clear_texture test no longer creates 1D textures 

    see gfx-rs#2323
    @Wumpf
    Wumpf committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    73d706f View commit details
    Browse the repository at this point in the history

  2. 3D textures are no longer cleared as render target since this isn't s… 

    …upported on Metal
    @Wumpf
    Wumpf committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    087145b View commit details
    Browse the repository at this point in the history

  3. fix deno building issue, fix formatting

    @Wumpf
    Wumpf committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    4b74c4f View commit details
    Browse the repository at this point in the history

  4. TextureInner::Surface can now be zero initialized

    @Wumpf
    Wumpf committed Dec 28, 2021
    Configuration menu
    Copy the full SHA
    f80a13d View commit details
    Browse the repository at this point in the history