Implement push constants for metal backend #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
reviewed
Dec 24, 2021
kvark
approved these changes
Dec 24, 2021
kvark
added
the
PR: needs back-porting
kvark
pushed a commit
to kvark/wgpu
that referenced
this pull request
Dec 29, 2021
* Implement push constants for metal backend * Clear push constants on reset; get upload size from layout
kvark
pushed a commit
that referenced
this pull request
Dec 29, 2021
* Implement push constants for metal backend * Clear push constants on reset; get upload size from layout
|
published in wgpu-hal-0.12.1 |
kvark
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #1825
Description
Implement push constants for the metal backend in
wgpu-hal. I adapted the implementation fromgfx-backend-metalv0.9, and tried to match its behaviour.Testing
Compute shader push constants tested with googlefonts/compute-shader-101 example from #2258.
Vertex shader push constants and reassignment tested with my own code from polystrip