hal: limit binding sizes to i32 #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1phyr
reviewed
Jan 7, 2022
| /// Interestingly, the index itself can't reach that high, because the minimum | ||
| /// element size is 4 bytes, but the compiler toolchain still computes the | ||
| /// offset at some intermediate point, internally, as i32. | ||
| pub const MAX_I32_BINDING_SIZE: u32 = 1 << 31; |
There was a problem hiding this comment.
I may miss something, but 1 << 31 does not fit in an i32, as the maximum value for it is (1 << 31) - 1.
I think that using i32::MAX as u32 instead could be less error-prone.
There was a problem hiding this comment.
The size doesn't need to fit into i32. It's the byte offsets that are internally converted into i32, and they are strictly less than the full binding size.
|
published in wgpu-hal-0.12.2 |
kvark
removed
the
PR: needs back-porting
kvark
added
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #2361
Description
Driver compiler toolchain produce an offset as i32 internally, we can't expose bindings larger than that until we start doing 64-bit indexing.
Testing
Untested