Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from cgmath to glam in examples #2544

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Switch from cgmath to glam in examples #2544

merged 4 commits into from
Mar 21, 2022

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Mar 20, 2022

Switch from cgmath to glam in examples.

There are now a few degrees to radians conversions, it might be worth switching everything to radians.

Testing
Ran changed examples

kvark
kvark reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

wgpu/examples/framework.rs Show resolved Hide resolved
wgpu/examples/mipmap/main.rs Show resolved Hide resolved
cwfitzgerald
cwfitzgerald requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, but otherwise LGTM

wgpu/examples/cube/main.rs Outdated Show resolved Hide resolved
wgpu/examples/water/main.rs Outdated Show resolved Hide resolved
@a1phyr
Copy link
Contributor Author

a1phyr commented Mar 21, 2022

What should we do with the failing skybox test ?

It used to multiply a view matrix by OPENGL_TO_WGPU_MATRIX, which is weird, but now I removed it, it fails.

@cwfitzgerald
Copy link
Member

If the output looks visually right, you need to remove the screenshots in the example directory then run cargo test --example skybox to regenerate them.

@cwfitzgerald cwfitzgerald merged commit b0da1a2 into gfx-rs:master Mar 21, 2022
@a1phyr a1phyr deleted the glam branch March 24, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark left review comments

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a1phyr @cwfitzgerald @kvark