Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal: fix some supported limits #2608

Merged
merged 1 commit into from
Apr 19, 2022
Merged

metal: fix some supported limits #2608

merged 1 commit into from
Apr 19, 2022

Conversation

jinleili
Copy link
Contributor

Description
Fixed max_inter_stage_shader_components according to the Metal feature set table and the implementation of WebKit:
截屏2022-04-18 15 29 30
https://github.com/WebKit/WebKit/blob/a438d3bb8e5cc0fa8fde2b9707fd446f0e0ed539/Source/WebGPU/WebGPU/HardwareLimits.mm#L99

Fixed max_compute_workgroup_storage_size :
截屏2022-04-18 16 25 08

https://github.com/WebKit/WebKit/blob/a438d3bb8e5cc0fa8fde2b9707fd446f0e0ed539/Source/WebGPU/WebGPU/HardwareLimits.mm#L66

Fixed max_compute_workgroup_size_xx

Testing
Tested on M1 Mac and iPhone 12, none of the wgpu samples were broken.

@kvark kvark merged commit 0b61a19 into gfx-rs:master Apr 19, 2022
@kvark kvark added the PR: needs back-porting PR with a fix that needs to land on crates label Apr 19, 2022
@cwfitzgerald cwfitzgerald removed the PR: needs back-porting PR with a fix that needs to land on crates label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants