Make GLES DeviceType unknown by default #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renoir is codename for AMD series of mainstream mobile and desktop APUs based on the Zen 2 CPU and Vega GPU microarchitectures succeeding Picasso.
kvark
approved these changes
May 12, 2022
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found out that my integrated GPU is not on
wgp-hallist.Thanks to that I realized that when I request
HighPerformanceadapter GLES one will always be selected instead of Vulkan one, because Vulkan reportsIntegratedGpuproperly, so it gets filtered out in favor of GLESDiscreteGpu(that in reality is not discrete).I could just add it to the list, but I don't think that's the right solution, it's an endless fight, and we will never have all integrated gpus on the list no matter what.
So I think the right solution is to just admit that we don't know what is the device type. So
DeviceType::Othershould be used, maybe the name does not fit the case well, but it directly maps toWGPUAdapterType_Unknowninwebgpu-nativeso I think it's right to use it for this.