fix: panic in Storage::get
#2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an
IdwithIndexout of bounds ofself.mapis given toStorage::contains,Storage::get, orStorage::get_mut, it panics due to directly indexing the Vec. This PR fixes that, and makescontainsreturn false, andget*returnErr(InvalidId)like they should.This also indirectly fixes a panic when
Device::as_halis invoked with an API that is not being used at the time.Testing
This was tested by creating a device with
Backends::Vulkan, and trying to get aDx12backend (Device::as_hal::<Dx12, _, _>) from it. It correctly gives the closure a None, instead of panicking as it did earlier.