Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement submission indexes #2700

Merged
merged 5 commits into from
Jun 5, 2022

Conversation

cwfitzgerald
Copy link
Member

Connections

Connected with #2698 and our whole backpressure story.

Description

This implements submission indexes so that compute workloads can properly implement backpressure.

I also found issues with our lifetime management, which is why every unit test I wrote is skipped. We are dropping the buffer immediately after the submission instead of properly waiting for it to finish gpu side execution. I tested these unit tests back before the tracker rewrite, so the tracker rewrite isn't at fault.

Testing

It has tests!

@cwfitzgerald cwfitzgerald force-pushed the submission-indexes branch 2 times, most recently from e94df11 to 862e59c Compare May 29, 2022 07:01
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward. I do have a suggestion.

wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/tests/common/mod.rs Outdated Show resolved Hide resolved
wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
wgpu-core/src/device/mod.rs Outdated Show resolved Hide resolved
cwfitzgerald and others added 2 commits June 4, 2022 01:56
Co-authored-by: Jim Blandy <jimb@red-bean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants