Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default features from wgpu-info #2753

Merged
merged 2 commits into from
Jun 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ jobs:
shell: bash
run: |
# run wgpu-info
cargo run --bin wgpu-info
cargo run --bin wgpu-info --features angle,vulkan-portability
# run unit and player tests
cargo nextest run -p wgpu-types -p wgpu-hal -p wgpu-core -p player --no-fail-fast
# run native tests
Expand Down
8 changes: 2 additions & 6 deletions wgpu-info/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ repository = "https://github.com/gfx-rs/wgpu"
keywords = ["graphics"]
license = "MIT OR Apache-2.0"

# Even if you aren't actually building `wgpu-info`,
# enabling the `angle` and `vulkan-portability` features of wgpu enables them for everything built in this workspace.
# This includes the web examples, which fail to compile when Vulkan is enabled,
# so disable that on web (by just disabling everything, since this won't compile for wasm anyway).
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
[dependencies]
env_logger = "0.9"
wgpu = { version = "0.12", path = "../wgpu", features = ["angle", "vulkan-portability"] }
wgpu = { version = "0.12", path = "../wgpu" }
2 changes: 2 additions & 0 deletions wgpu-info/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ This is a command line utility that does two different functions.

When called with no arguments, wgpu-info will list all adapters visible to wgpu and all the information about them we have.

For OpenGL on platforms other than Linux add the `angle` feature, for Vulkan on macOS add the `vulkan-portability` feature.

```
cargo run --bin wgpu-info
```
Expand Down