Expect shader_primitive_index tests to fail on AMD RADV POLARIS12. #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblandy
added
external: driver-bug
jimblandy
force-pushed
the
expect-fail-primitive-index-amd
branch
from
32885bd
to
eb05749
Compare
cwfitzgerald
requested changes
Jun 9, 2022
On Fedora, mesa-vulkan-drivers 22.0.3 AMD RADV POLARIS12 just colors both the NE and SW corners red. There's no blue. (NW and SE are white, as expected.) I suspect this means that the primitive ID is always being passed as zero. This is probably not just due to a difference in rasterization: I tried enlarging the texture to 4x4 and shifting the triangles to ensure that there was a pixel in each quadrant that was fully covered. With Vulkan "llvmpipe (LLVM 14.0.0, 256 bits)", the unmodified test passes. This is probably limited to Linux, but `wgpu_tests::common::TestParameters` doesn't have a slot for that. Fixes gfx-rs#2751.
jimblandy
force-pushed
the
expect-fail-primitive-index-amd
branch
from
eb05749
to
2409853
Compare
cwfitzgerald
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Fedora, mesa-vulkan-drivers 22.0.3 AMD RADV POLARIS12 just colors both the NE and SW corners red. There's no blue. (NW and SE are white, as expected.) I suspect this means that the primitive ID is always being passed as zero.
This is probably not just due to a difference in rasterization: I tried enlarging the texture to 4x4 and shifting the triangles to ensure that there was a pixel in each quadrant that was fully covered.
With Vulkan "llvmpipe (LLVM 14.0.0, 256 bits)", the unmodified test passes.
This is probably limited to Linux, but
wgpu_tests::common::TestParametersdoesn't have a slot for that.Fixes #2751.