Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal | vulkan-portability: extract the generic code into get_metal_layer #2826

Merged
merged 2 commits into from
Jul 11, 2022
Merged

metal | vulkan-portability: extract the generic code into get_metal_layer #2826

merged 2 commits into from
Jul 11, 2022

Conversation

jinleili
Copy link
Contributor

@jinleili jinleili commented Jul 1, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Testing
Tested on metal and vaulkan-portability

cwfitzgerald
cwfitzgerald approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit ecf3f5e into gfx-rs:master Jul 11, 2022
@jinleili jinleili deleted the get_metal_layer branch July 11, 2022 05:02
@jimblandy jimblandy mentioned this pull request Aug 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinleili @cwfitzgerald