Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2840 #2842

Merged
merged 2 commits into from
Jul 3, 2022
Merged

Fixes #2840 #2842

merged 2 commits into from
Jul 3, 2022

Conversation

simbleau
Copy link
Contributor

@simbleau simbleau commented Jul 3, 2022 •
edited
Loading

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
This fixes #2840

Description
AutoNoVSync should fall back on Fifo as a last resort. This is important for Web, since Web only has Fifo. Documentation already shows this should use Fifo, but it was missing.

cwfitzgerald
cwfitzgerald approved these changes Jul 3, 2022
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) July 3, 2022 01:47
@cwfitzgerald cwfitzgerald merged commit 72a4ef9 into gfx-rs:master Jul 3, 2022
cwfitzgerald pushed a commit that referenced this pull request Jul 3, 2022
@simbleau @cwfitzgerald
Fixes #2840 (#2842)
84793bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwfitzgerald cwfitzgerald cwfitzgerald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v0.13 - BrowserWebGpu - AutoNoVSync does not properly fallback
2 participants
@simbleau @cwfitzgerald