Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winit 0.27 Update and raw-window-handle 0.5 #2918

Merged
merged 13 commits into from
Aug 4, 2022
Merged

winit 0.27 Update and raw-window-handle 0.5 #2918

merged 13 commits into from
Aug 4, 2022

Conversation

wyatt-herkamp
Copy link
Contributor

@wyatt-herkamp wyatt-herkamp commented Jul 27, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Closes #2928

Description
Winit released 0.27 today. With this decoupling Display and Window Handles rust-windowing/raw-window-handle#92

If I am within the Window Handle match block I get the Display handle via an if let statement returning with an Error if the type does not match.
Testing
Ran the examples on a Windows 11 environment x86 AMD/Nvidia setup

@wyatt-herkamp wyatt-herkamp marked this pull request as ready for review July 27, 2022 00:11
@wyatt-herkamp wyatt-herkamp changed the title [WIP] winit 0.27 Update and raw-window-handle 0.5 winit 0.27 Update and raw-window-handle 0.5 Jul 27, 2022
@dhardy
Copy link
Contributor

dhardy commented Jul 27, 2022

Tested on Fedora / 5.18.10-100.fc35.x86_64 / RX570: examples work except

  • mipmap which requires feature wgpu::Features::WRITE_TIMESTAMP_INSIDE_PASSES to be enabled
  • conservative-raster (doesn't work on my GPU)

@wyatt-herkamp
Copy link
Contributor Author

wyatt-herkamp commented Jul 31, 2022

This bug will be fixed in rust-lang/rust#97791 that comes in 1.63

@cwfitzgerald
Copy link
Member

So this would bump our MSRV to 1.63?

@wyatt-herkamp
Copy link
Contributor Author

So this would bump our MSRV to 1.63?

Apparently so.

@cwfitzgerald
Copy link
Member

Could you have this PR bump the MSRV?

@emilk
Copy link
Contributor

emilk commented Aug 1, 2022

winit 0.27.1 has been released which lowers the MSRV to 1.57.0: https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md#0271-2022-07-30

@wyatt-herkamp
Copy link
Contributor Author

winit 0.27.1 has been released which lowers the MSRV to 1.57.0: rust-windowing/winit@master/CHANGELOG.md#0271-2022-07-30

Alright all builds were able to run https://github.com/wyatt-herkamp/wgpu/actions/runs/2774303424

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, some comments

wgpu-hal/src/vulkan/instance.rs Outdated Show resolved Hide resolved
wgpu-hal/Cargo.toml Outdated Show resolved Hide resolved
wgpu/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@cwfitzgerald
Copy link
Member

Enscripten CI is mad

@wyatt-herkamp
Copy link
Contributor Author

Enscripten CI is mad

It doesn't like importing RawDisplayHandle as Rdh because when the one feature is not enabled the import is not used.

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) August 4, 2022 06:06
@cwfitzgerald cwfitzgerald merged commit f7526ae into gfx-rs:master Aug 4, 2022
@emilk
Copy link
Contributor

emilk commented Aug 4, 2022

🥳

Question: what is the release schedule for wgpu? i.e. when can I expect this to be released?

@cwfitzgerald
Copy link
Member

Currently we're on a loose 90 day schedule, without making up for lost time so next release will be late September - the calculated date is listed on the milestone for 0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for raw-window-handle 0.5
4 participants