Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose driver info in AdapterInfo #3037

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Sep 20, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Description
Exposes driver info to users via AdapterInfo.

This is a native only feature and has been implemented for Vulkan so far. For Vulkan, this may also be useful for future workaround code.

@i509VCB i509VCB marked this pull request as draft September 20, 2022 01:47
@i509VCB i509VCB marked this pull request as ready for review September 20, 2022 01:54
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

wgpu-hal/src/gles/adapter.rs Outdated Show resolved Hide resolved
This is a native only feature and has been implemented for Vulkan so far.
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) September 21, 2022 02:27
@cwfitzgerald cwfitzgerald merged commit 061e04b into gfx-rs:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants