Better error message #3099
Closed
Better error message #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could state what size we found? |
|
The more information the merrier! |
|
Could the shader's |
grovesNL
reviewed
Oct 16, 2022
| @@ -371,6 +371,8 @@ pub enum CreateRenderPipelineError { | |||
| stage: wgt::ShaderStages, | |||
| error: String, | |||
| }, | |||
| #[error("shader group {group} binding {binding} must be 16bit aligned as device does not support DownlevelFlags `BUFFER_BINDINGS_NOT_16_BYTE_ALIGNED`")] | |||
There was a problem hiding this comment.
This should be bytes instead of bits
|
Poke from triage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes #2832
Description
Previous error message was the generic downflags error message for
BUFFER_BINDINGS_NOT_16_BYTE_ALIGNEDthat didn't highlight that if it was 16 bit aligned then this is supported. But it wasn't clear which shader group / bind was not aligned.New error message:
Also have switched the code around to check the flag once as if it's set then we can skip the check entirely.
Testing
I've tested that I get the updated error locally in the browser.