Added support for MSAA(x2,x8) beyond WEBGPU restrictions for native a… #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Oct 26, 2022
|
Hi @cwfitzgerald , let me know what you think! |
cwfitzgerald
requested changes
Oct 28, 2022
|
hey @cwfitzgerald, please take a look !. |
cwfitzgerald
requested changes
Nov 2, 2022
This was referenced Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Closes Can't set MSAA samples beyond 4 .
Description
Native adapters can now use MSAA x2 and x8 if it's supported , previously only x1 and x4 were supported .
Testing
Tested locally on chrome canary , macOS(intel) , win10