Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Ids a u64 internally #3178

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Nov 5, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
#3051

Description
This is going to be needed for future dynamic dispatch work, feature dependent types need to go for this to happen.

cc @TheOnlyMrCat

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #3178 (d8a8713) into master (6ed103e) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head d8a8713 differs from pull request most recent head 7e82824. Consider uploading reports for the commit 7e82824 to get more accurate results

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   64.73%   64.65%   -0.09%     
==========================================
  Files          81       81              
  Lines       38747    38799      +52     
==========================================
+ Hits        25084    25085       +1     
- Misses      13663    13714      +51     
Impacted Files Coverage Δ
wgpu-core/src/id.rs 81.25% <0.00%> (-2.63%) ⬇️
wgpu/src/backend/direct.rs 55.25% <0.00%> (ø)
wgpu/src/lib.rs 50.89% <ø> (-1.93%) ⬇️
wgpu-hal/src/dx12/descriptor.rs 88.05% <0.00%> (+0.49%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This is going to be needed for future dynamic dispatch work
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very chilly beans

@cwfitzgerald cwfitzgerald merged commit 0e937c8 into gfx-rs:master Nov 9, 2022
@cwfitzgerald cwfitzgerald mentioned this pull request Nov 9, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants