Improve locking safety for Registry #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify, even though parts of this PR are to be scrapped, at least the change of |
grovesNL
approved these changes
Nov 28, 2018
wgpu-bindings/Cargo.toml
Outdated
| @@ -10,4 +10,5 @@ authors = [ | |||
| default = [] | |||
|
|
|||
| [dependencies] | |||
| cbindgen = { git = "https://github.com/eqrion/cbindgen.git" } | |||
| #cbindgen = "0.6.7" | |||
| cbindgen = { git = "https://github.com/eqrion/cbindgen" } | |||
There was a problem hiding this comment.
We could also use my branch for now if we're blocked by the header changes
| @@ -7,7 +7,6 @@ use hal; | |||
|
|
|||
|
|
|||
| bitflags! { | |||
| #[repr(transparent)] | |||
There was a problem hiding this comment.
I assume this is temporary?
wgpu-native/src/registry/remote.rs
Outdated
|
|
||
| pub struct Items<T> { | ||
| next_id: Id, | ||
| next_id: u32, |
wgpu-native/src/registry/remote.rs
Outdated
| @@ -35,11 +32,11 @@ impl<T> super::Items<T> for Items<T> { | |||
| id | |||
| } | |||
|
|
|||
| fn get(&self, id: Id) -> super::Item<T> { | |||
| fn get(&self, id: Id) -> & T { | |||
|
Thanks for the review! All the concerns should be addressed now. |
Build succeeded |
mitchmindtree
pushed a commit
to mitchmindtree/wgpu
that referenced
this pull request
Feb 23, 2020
32: Add conversion matrix from OpenGL to wgpu r=kvark a=dragly The matrices in the examples are given in an OpenGL-like coordinate system, while a Vulkan-like coordinate system is used by wgpu. This was previously partially corrected in the shader and by flipping the up axis of the camera, but left the x-axis mirrored in the final result. This change adds a conversion matrix to framework.rs that can be used to convert from OpenGL to wgpu. This also allows us to set the winding-order to counter-clockwise, which matches the ordering in the data. Co-authored-by: Svenn-Arne Dragly <dragly@cognite.com> Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
32: Add conversion matrix from OpenGL to wgpu r=kvark a=dragly The matrices in the examples are given in an OpenGL-like coordinate system, while a Vulkan-like coordinate system is used by wgpu. This was previously partially corrected in the shader and by flipping the up axis of the camera, but left the x-axis mirrored in the final result. This change adds a conversion matrix to framework.rs that can be used to convert from OpenGL to wgpu. This also allows us to set the winding-order to counter-clockwise, which matches the ordering in the data. Co-authored-by: Svenn-Arne Dragly <dragly@cognite.com> Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ideal: we shouldn't be mutably locking anything for adding/removing objects in
localpath. But at least it makes it safe, for now.