-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wgpu spell checking #3228
wgpu spell checking #3228
Conversation
At the moment "compute pass" is used and this matches more closely with the webgpu specification.
Empty docs are pointless, we should fill these in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Poke from triage |
I believe I have resolved when @grovesNL has mentioned |
Codecov Report
@@ Coverage Diff @@
## master #3228 +/- ##
==========================================
+ Coverage 64.70% 65.60% +0.90%
==========================================
Files 81 82 +1
Lines 38819 39468 +649
==========================================
+ Hits 25118 25894 +776
+ Misses 13701 13574 -127
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
A clippy lint has been proposed to help prevent empty doc comments in the future: rust-lang/rust-clippy#9931
Description
Probably best reviewed one commit at a time.
Fixes a few spelling errors
Changes instances of
renderpass
torender pass
to matchcompute pass
and the webgpu spec usingrender pass
.Fills in empty doc comments in wgpu-types and wgpu.