Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu spell checking #3228

Merged
merged 4 commits into from
Dec 2, 2022
Merged

wgpu spell checking #3228

merged 4 commits into from
Dec 2, 2022

Conversation

i509VCB
Copy link
Contributor

@i509VCB i509VCB commented Nov 23, 2022

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
A clippy lint has been proposed to help prevent empty doc comments in the future: rust-lang/rust-clippy#9931

Description
Probably best reviewed one commit at a time.

Fixes a few spelling errors

Changes instances of renderpass to render pass to match compute pass and the webgpu spec using render pass.

Fills in empty doc comments in wgpu-types and wgpu.

At the moment "compute pass" is used and this matches more closely with the webgpu specification.
Empty docs are pointless, we should fill these in
Copy link
Collaborator

@grovesNL grovesNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@cwfitzgerald
Copy link
Member

Poke from triage

@i509VCB
Copy link
Contributor Author

i509VCB commented Dec 2, 2022

I believe I have resolved when @grovesNL has mentioned

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #3228 (790d414) into master (04d12ba) will increase coverage by 0.90%.
The diff coverage is 64.58%.

@@            Coverage Diff             @@
##           master    #3228      +/-   ##
==========================================
+ Coverage   64.70%   65.60%   +0.90%     
==========================================
  Files          81       82       +1     
  Lines       38819    39468     +649     
==========================================
+ Hits        25118    25894     +776     
+ Misses      13701    13574     -127     
Impacted Files Coverage Δ
player/src/lib.rs 53.31% <ø> (ø)
wgpu-core/src/id.rs 81.25% <0.00%> (-2.63%) ⬇️
wgpu-core/src/lib.rs 96.55% <ø> (ø)
wgpu-core/src/present.rs 0.00% <0.00%> (ø)
wgpu-core/src/resource.rs 25.13% <ø> (ø)
wgpu-core/src/track/stateless.rs 98.16% <ø> (-0.21%) ⬇️
wgpu-hal/src/dx11/device.rs 0.00% <0.00%> (ø)
wgpu-hal/src/empty.rs 0.00% <ø> (ø)
wgpu-hal/src/lib.rs 26.21% <ø> (ø)
wgpu/src/backend/direct.rs 56.44% <1.78%> (+1.34%) ⬆️
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwfitzgerald cwfitzgerald merged commit 88acaf7 into gfx-rs:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants