-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test setup for WebAssembly+WebGL #3238
Test setup for WebAssembly+WebGL #3238
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3238 +/- ##
==========================================
+ Coverage 65.60% 65.63% +0.03%
==========================================
Files 82 82
Lines 39468 39474 +6
==========================================
+ Hits 25894 25910 +16
+ Misses 13574 13564 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ca95dad
to
907507b
Compare
907507b
to
87e1161
Compare
87e1161
to
fd91517
Compare
This reverts commit 8a3f00f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I know you're probably not done yet, but some small comments)
Looking great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops wrong button
wasm-bindgen-test with headless chrome under linux is broken for now. https://github.com/codeart1st/wgpu-layers/actions/runs/3558060356/jobs/5976466514 I only get it working with a real physical GPU, but software vulkan rendering is broken in chrome with llvmpipe or swiftshader. Maybe you have more luck to get it working. |
This PR will only be testing webgl - so we should be okay. With how unstable webgpu is anyway, I wouldn't want to commit to testing it yet. |
One thing I was not able yet to wrap my head around is, why clippy fails for the PR in the official repo, but it works (for the same commit) on my fork: https://github.com/haraldreingruber/wgpu/actions/runs/3604776801/jobs/6074498868 Here is the same job in upstream: https://github.com/gfx-rs/wgpu/actions/runs/3604776894/jobs/6074499138 Any ideas? Maybe a different cache content? |
This is because your fork is running your code, and the PR is running against the result of merging your code into master. There are changes on master that cause the code to break. Merging in master to this branch will let you fix the problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
by @cwfitzgerald Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Yes, that's correct. At least it is the case for
I am not sure how to do that. I guess we only want to modify test code and don't want to change wgpu itself? |
I think the most reasonable is to fix the simple to fix problems and leave the more fundamental problems for later. For the ones that panic for control flow:
For For |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, plus the minor failure stuff, then we're good to go! Thanks for bringing this to completion!
Curious why headless firefox didn't work - it works locally? |
Yes, it works on my Windows machine. |
8348a6b
to
cf4a05c
Compare
All tests fail with One guess would be that it's related to FF not working with software rendering in GH CI? On the other hand, I did also try running it with the "gfx.prefer-mesa-llvmpipe" config flag. |
Interesting, let's leave FF to a followup, it's not terribly important anyway. |
8e8ed89
to
da9eec8
Compare
Thanks! It worked for Any idea why this workaround doesn't work in this case but does for the other? |
Yeah that means it's not getting redirected to the error scope correctly - lets just skip that one and follow up later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! I'll add a changelog entry, then I'll merge it!
Thanks for all the support! |
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
#3162
Description
This PR runs wasm-bindgen-tests in a headless-chrome (WebGL backend only).