-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement queue.copy_external_image_to_texture for WebGL2 and improve WebGPU Impl #3288
Implement queue.copy_external_image_to_texture for WebGL2 and improve WebGPU Impl #3288
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
==========================================
- Coverage 64.50% 64.42% -0.08%
==========================================
Files 86 86
Lines 42691 42776 +85
==========================================
+ Hits 27536 27558 +22
- Misses 15155 15218 +63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
164a4a7
to
fcd3d4f
Compare
fcd3d4f
to
917e779
Compare
1fa2918
to
fbdb2df
Compare
6cc084b
to
c236020
Compare
c236020
to
41fc00e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a few comments, otherwise it looks good!
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Still todo:
Connections
Closes #1888.
Follows up on #2781.
Description
Implements copy_external_image_to_texture fully on both WebGPU and WebGL - including all 4 different types that are supported by WebGPU.
Testing
Testing todo.