Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blit shader comment #3301

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

Davidster
Copy link
Contributor

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
This is just a little comment I added on this same shader when I copied it into my project, I figured it might be helpful for others to explain how the vertex shader works. I know that comments generally become outdated over time so I'd understand if this isn't wanted in the project.

Testing
Tested locally

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Merging #3301 (b3704e5) into master (0e4c7dd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3301   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files          82       82           
  Lines       39490    39490           
=======================================
  Hits        25931    25931           
  Misses      13559    13559           
Impacted Files Coverage Δ
wgpu-core/src/hub.rs 60.82% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@cwfitzgerald cwfitzgerald merged commit f14bee6 into gfx-rs:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants