Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added texture metadata #3346

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Conversation

kurtkuehnert
Copy link
Contributor

Description

This PR exposes the metadata/attributes of a Texture, according to the WebGpu spec: https://www.w3.org/TR/webgpu/#gputexture.

This is a draft because I am unsure how to set those attributes for the SurfaceTextures (see the Todo).
I would appreciate any guidance you can give me.

wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Outdated Show resolved Hide resolved
@kurtkuehnert kurtkuehnert marked this pull request as ready for review January 5, 2023 08:59
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

G2G after some small things

wgpu/src/lib.rs Outdated Show resolved Hide resolved
wgpu/src/lib.rs Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Merging #3346 (7f48771) into master (186a29c) will increase coverage by 0.06%.
The diff coverage is 8.06%.

@@            Coverage Diff             @@
##           master    #3346      +/-   ##
==========================================
+ Coverage   64.43%   64.50%   +0.06%     
==========================================
  Files          86       86              
  Lines       42622    42691      +69     
==========================================
+ Hits        27462    27536      +74     
+ Misses      15160    15155       -5     
Impacted Files Coverage Δ
wgpu/src/lib.rs 51.14% <8.06%> (-0.09%) ⬇️
wgpu-hal/src/dx12/command.rs 73.46% <0.00%> (-0.29%) ⬇️
wgpu-hal/src/vulkan/device.rs 75.84% <0.00%> (-0.07%) ⬇️
wgpu-hal/src/dx12/mod.rs 27.27% <0.00%> (ø)
wgpu/src/context.rs 53.32% <0.00%> (+0.04%) ⬆️
wgpu/src/backend/direct.rs 56.87% <0.00%> (+0.05%) ⬆️
wgpu-core/src/hub.rs 60.82% <0.00%> (+0.15%) ⬆️
wgpu-hal/src/dx12/descriptor.rs 88.11% <0.00%> (+0.49%) ⬆️
wgpu-hal/src/vulkan/instance.rs 38.37% <0.00%> (+0.76%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit c1a0912 into gfx-rs:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants