Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vk] Set WEBGPU_TEXTURE_FORMAT_SUPPORT downlevel flag depending on the proper format support #3367

Merged
merged 3 commits into from
Jan 10, 2023
Merged

[vk] Set WEBGPU_TEXTURE_FORMAT_SUPPORT downlevel flag depending on the proper format support #3367

merged 3 commits into from
Jan 10, 2023

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jan 10, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections

Description
Require either S8_UINT or D24_UNORM_S8_UINT for stencil8
Require either D24_UNORM_S8_UINT or D32_SFLOAT_S8_UINT for depth24plus-stencil8
Require D32_SFLOAT for depth32float (and as fallback for depth24plus)
Require all formats listed above to support SAMPLED_IMAGE and DEPTH_STENCIL_ATTACHMENT flags.

Testing

@teoxoy teoxoy merged commit 80d2377 into gfx-rs:master Jan 10, 2023
@teoxoy teoxoy deleted the vk-require-formats branch January 10, 2023 15:33
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
WebGPU Specification V1
Development

Successfully merging this pull request may close these issues.
2 participants
@teoxoy @nical