Fix dx12 shader validation errors when dxil.dll isn't available in the local scope. #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
reviewed
Jan 29, 2023
|
Wouldn't it be better to completely disable implicit validation and do it explicitly only? |
Probably, it might even be faster as well. |
cwfitzgerald
requested changes
Feb 1, 2023
cwfitzgerald
added
the
PR: needs back-porting
cwfitzgerald
approved these changes
Feb 2, 2023
cwfitzgerald
pushed a commit
to cwfitzgerald/wgpu
that referenced
this pull request
Feb 9, 2023
…e local scope. (gfx-rs#3434) * Fix dx12 shader validation errors when dxil.dll isn't available in the local scope. * changelog * clippy * always explicitly validate shaders to simplify code * destructor ordering
cwfitzgerald
pushed a commit
that referenced
this pull request
Feb 9, 2023
…e local scope. (#3434) * Fix dx12 shader validation errors when dxil.dll isn't available in the local scope. * changelog * clippy * always explicitly validate shaders to simplify code * destructor ordering
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3433
Description
When using a custom path for dxil.dll that isn't in the local scope, dxcompiler's automatic validation will silently fail. This makes it so that if dxil.dll has a custom path, then we disable automatic validation and do manual validation post compilation instead.
Testing
Tested against
hello-trianglewith a customdxil.dllpath and nodxil.dllin the wgpu folder.