Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MULTISAMPLE_X16 texture format feature flag #3454

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

Dinnerbone
Copy link
Contributor

@Dinnerbone Dinnerbone commented Feb 3, 2023

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
None

Description
MSAA x16 is at the limit of what most hardware & backends support, and it's not nearly as common as x4 or x8, but it is sometimes supported. We'd like to be able to see and use it when possible, as some of our content unfortunately requests it. This PR adds the flag so we can see when x16 is supported.

Testing
Manually tested, and all existing tests pass

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work!

@teoxoy teoxoy merged commit 238697c into gfx-rs:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants