[metal] Fix metal erroring on an array_stride of 0
#3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Mar 1, 2023
teoxoy
force-pushed
the
fix-metal-stride-0
branch
2 times, most recently
from
8dfb6e0
to
145a85a
Compare
cwfitzgerald
requested changes
Mar 3, 2023
teoxoy
force-pushed
the
fix-metal-stride-0
branch
from
145a85a
to
f6bc9d1
Compare
teoxoy
force-pushed
the
fix-metal-stride-0
branch
from
f6bc9d1
to
150ed2b
Compare
cwfitzgerald
approved these changes
Mar 3, 2023
teoxoy
force-pushed
the
fix-metal-stride-0
branch
from
150ed2b
to
cca15cb
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Description
Setting
array_strideto 0 resulted in the following error:Fixed it by calculating the stride and using metal's Constant step function + a rate of 0.
see https://developer.apple.com/documentation/metal/mtlvertexbufferlayoutdescriptor/1515341-stepfunction?language=objc
Testing
Should be covered by CTS; tested locally by setting
array_strideto 0 in one of the tests.