Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the queue state between each command buffer on queue submit #3593

Conversation

jleibs
Copy link
Contributor

@jleibs jleibs commented Mar 15, 2023

This is a port of #3589 to master

The move of reset_state from outside to inside the loop matches the previous behavior here: https://github.com/gfx-rs/gfx/blob/master/src/backend/gl/src/queue.rs#L1142

Given the command encoder assumes a default state this seems to be the only safe behavior to avoiding leaking state between buffers.

Additionally reset the state of SAMPLE_ALPHA_TO_COVERAGE as part of a queue reset.

Checklist

  • Run cargo clippy.
  • Run RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

@cwfitzgerald cwfitzgerald merged commit 68b0b24 into gfx-rs:master Mar 22, 2023
@Wumpf Wumpf deleted the jleibs/gles_alpha_to_coverage_reset_state_main branch March 22, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants