-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix depth stencil attachment downcast for WebGPU #3670
Conversation
seems to fix it for me 👍 (as in, I have other issues so still nothing renders, but at least not that error anymore) |
works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Why does this work though? |
@cwfitzgerald this is the subtle downcasting issue I mentioned on my other PR. In this case We could probably build some of this into our own |
Checklist
cargo clippy
.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Fixes #3663 (maybe?)
Description
Untested but I believe we should be using
as_ref()
here insteadTesting
Untested